Enhance subscribers, queryables and liveliness tokens propagation to improve scalability #814
Conversation
|
@OlivierHecart If this pull request contains a bugfix or a new feature, then please consider using |
* Add client writer-side filtering * Reimplement liveliness with interests * Fix writer-side filtering before receiving FinalInterest
| impl CurrentFutureTrait for InterestMode { | ||
| #[inline] | ||
| fn future(&self) -> bool { | ||
| self == &InterestMode::Future || self == &InterestMode::CurrentFuture |
There was a problem hiding this comment.
So no strong opinion on this so it's simply to have a written trace somewhere.
The InterestMode enum as an abstraction on the Current & Future flags, make the switch to an Interest Final message clearer but at the same time it creates that CurrentFuture state that doesn't represent anything specific.
On the other side of the coin, if we don't have this enum, we keep Current and Future as separate flags but it suddenly switch to Interest Final out of the blue which is confusing to someone who doesn't know the Interest spec.
For Pico I chose the latter because it's simpler, I don't have to deal with an enum.
OlivierHecart
changed the base branch from
protocol_changes_bad_main_merged
to
protocol_changes
OlivierHecart
changed the title
No description provided.